lib: return undefined for localStorage without file #61333
Merged
+58
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Jan 10, 2026
mcollina
force-pushed
the
localstorage-undefined
branch
from
ebc1299 to
c85a48b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61333 +/- ##
==========================================
- Coverage 88.54% 88.51% -0.04%
==========================================
Files 704 704
Lines 208734 208762 +28
Branches 40271 40272 +1
==========================================
- Hits 184823 184778 -45
- Misses 15932 15977 +45
- Partials 7979 8007 +28
🚀 New features to boost your workflow:
|
avivkeller
reviewed
Jan 11, 2026
mcollina
force-pushed
the
localstorage-undefined
branch
from
c85a48b to
5b17977
Compare
Make localStorage return undefined and emit a warning when
--localstorage-file is not provided. Mark the property as
non-enumerable to avoid breaking {...globalThis}.
Fixes: nodejs#60303
mcollina
force-pushed
the
localstorage-undefined
branch
from
5b17977 to
b044f0a
Compare
anonrig
approved these changes
Jan 11, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
mcollina
added
notable-change
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fa70327 |
aduh95
added
the
semver-major
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
Make localStorage return undefined and emit a warning when
--localstorage-file is not provided. Mark the property as
non-enumerable to avoid breaking {...globalThis}.
Fixes: nodejs#60303
PR-URL: nodejs#61333
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make localStorage return undefined and emit a warning when
--localstorage-file is not provided. Mark the property as
non-enumerable to avoid breaking {...globalThis}.
Fixes: #60303